Fix the Text class package change in example plugins #128316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
💚 Backport successful
|
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
May 22, 2025
prdoyle
pushed a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 23, 2025
|
I'll backport this as part of #128406. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 23, 2025
* Improve TestBuildInfoPluginFuncTest (#128322) * Use walkFileTree for extractModuleNameFromDirectory * More tests in TestBuildInfoPluginFuncTest * Remove stray line from debugging * [CI] Auto commit changes from spotless * Eliminate List.reversed() call --------- Co-authored-by: elasticsearchmachine <[email protected]> * Fix the Text class package change in example plugins (#128316) --------- Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Lorenzo Dematté <[email protected]>
This was referenced May 26, 2025
JVerwolf
pushed a commit
that referenced
this pull request
May 26, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 26, 2025
* Revert "Fix the Text class package change in example plugins (elastic#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (elastic#127666)" This reverts commit db0c3c7.
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 26, 2025
* Revert "Fix the Text class package change in example plugins (elastic#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (elastic#127666)" This reverts commit db0c3c7.
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 26, 2025
* Revert "Fix the Text class package change in example plugins (elastic#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (elastic#127666)" This reverts commit db0c3c7.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 26, 2025
* Revert changes to Text class (#128483) * Revert "Fix the Text class package change in example plugins (#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (#127666)" This reverts commit db0c3c7. * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 27, 2025
* Revert "Fix the Text class package change in example plugins (#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (#127666)" This reverts commit db0c3c7. Co-authored-by: Lorenzo Dematté <[email protected]>
jordan-powers
added a commit
that referenced
this pull request
Jun 4, 2025
This PR is a precursor to #126492. It does three things: 1. Move org.elasticsearch.common.text.Text from :server to org.elasticsearch.xcontent.Text in :libs:x-content. 2. Refactor the Text class to use a new EncodedBytes record instead of the elasticsearch BytesReference. 3. Add the XContentString interface, with the Text class implementing that interface. These changes were originally implemented in #127666 and #128316, however they were reverted in #128484 due to problems caused by the mutable nature of java ByteBuffers. This is resolved by instead using a new immutable EncodedBytes record.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 4, 2025
This PR is a precursor to #126492. It does three things: 1. Move org.elasticsearch.common.text.Text from :server to org.elasticsearch.xcontent.Text in :libs:x-content. 2. Refactor the Text class to use a new EncodedBytes record instead of the elasticsearch BytesReference. 3. Add the XContentString interface, with the Text class implementing that interface. These changes were originally implemented in #127666 and #128316, however they were reverted in #128484 due to problems caused by the mutable nature of java ByteBuffers. This is resolved by instead using a new immutable EncodedBytes record. (cherry picked from commit de40ac4) # Conflicts: # server/src/main/java/org/elasticsearch/search/fetch/subphase/highlight/DefaultHighlighter.java # server/src/test/java/org/elasticsearch/common/xcontent/BaseXContentTestCase.java # server/src/test/java/org/elasticsearch/search/fetch/subphase/highlight/HighlightFieldTests.java # test/framework/src/main/java/org/elasticsearch/search/SearchResponseUtils.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #127666 we changed the package for the Text class; example plugins however are not part of the source folders in Intellij and are not built as part of the normal CI process, so changes in example plugins were not done.
This PR updates the missing changes to the package.
I don't know if the CI will pick up this and build them, but anyway I run the build locally and it passes (build scan here): https://gradle-enterprise.elastic.co/s/nlajrzz3gpzoe